Sam Reed [Sat, 19 Feb 2011 01:02:56 +0000 (01:02 +0000)]
More function and variable documentation
Sam Reed [Sat, 19 Feb 2011 00:44:38 +0000 (00:44 +0000)]
More function level documentation
Fixup some indenting
Sam Reed [Sat, 19 Feb 2011 00:30:18 +0000 (00:30 +0000)]
More parameter documentation
Sam Reed [Fri, 18 Feb 2011 23:56:08 +0000 (23:56 +0000)]
More function level documentation
Platonides [Fri, 18 Feb 2011 23:44:18 +0000 (23:44 +0000)]
Follow up r63584. The change of resetArticleID() could have all kinds of
side effects, given that it stops lazy cache fillings.
Sam Reed [Fri, 18 Feb 2011 23:42:19 +0000 (23:42 +0000)]
Followup r49655
I'd guess there's never been a Title::newFromTitle method, swapping for Title::newFromText
Sam Reed [Fri, 18 Feb 2011 23:34:24 +0000 (23:34 +0000)]
Parameter documentation
Sam Reed [Fri, 18 Feb 2011 23:21:48 +0000 (23:21 +0000)]
Explicitally define some variables
Function documentation
Sam Reed [Fri, 18 Feb 2011 22:59:01 +0000 (22:59 +0000)]
Fixup assignment in loop
comment out undefined variable used in function call
Sam Reed [Fri, 18 Feb 2011 22:58:02 +0000 (22:58 +0000)]
Mark a fixme comment in Oracle DB file for undefined variable
Add documentation
Sam Reed [Fri, 18 Feb 2011 22:49:56 +0000 (22:49 +0000)]
Fixup whitespace, brackets etc
Remove usage of @
Mark A. Hershberger [Fri, 18 Feb 2011 21:54:19 +0000 (21:54 +0000)]
re bug #25523: add mime.info and mime.types for *.dwg files so that when people add dwg to $wgFileExtensions, they can move files.
Raimond Spekking [Fri, 18 Feb 2011 21:02:18 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-18 20:25:00 UTC)
Raimond Spekking [Fri, 18 Feb 2011 18:35:08 +0000 (18:35 +0000)]
Fix invalid HTML introduced in r68096: Xml::buildForm() adds <table></table> too
Alexandre Emsenhuber [Fri, 18 Feb 2011 16:03:07 +0000 (16:03 +0000)]
* Added a third parameter to ChangeTags::buildTagFilterSelector() to pass the Title object instead of using $wgTitle, only used when the second parameter is true (no such call both in core and extensions)
* Expanded documentation
Raimond Spekking [Fri, 18 Feb 2011 15:14:08 +0000 (15:14 +0000)]
Follow-up r82391 per Nikerabbit's CR: Fix it in a better way
Roan Kattouw [Fri, 18 Feb 2011 14:21:52 +0000 (14:21 +0000)]
Remove comment that makes no sense post r82399
Tim Starling [Fri, 18 Feb 2011 14:18:26 +0000 (14:18 +0000)]
Fix comments and whitespace for \\\\ .
Tim Starling [Fri, 18 Feb 2011 14:09:03 +0000 (14:09 +0000)]
JavaScriptDistiller fixes:
* Removed some repeated subexpressions, /(.)*/ etc. These cause the stack space to be rapidly exhausted, leading to a segfault for malicious input. I replaced the ([\r\n]|.) subexpressions with a dot with a /s modifier. Added a pcre.recursion_limit hack to take care of the rest.
* Supported assertions and non-capturing subpatterns in ParseMaster::add() by recognising that parentheses that aren't followed by "?" are capturing. Used another assertion to do this.
* Fixed a bug whereby if a single-line comment had a slash in it, it was recognised as a regex instead of a comment. This occurred because the leading whitespace caused the regex regex to match at an earlier string position than the comment regex, giving it undue precedence. This was the subject of several reports on IRC and the main reason for me starting work on JavaScriptDistiller. Used a lookbehind assertion.
* Give comments precedence over regexes and strings where there is ambiguity at the same string location. Not sure if this does anything, but it seemed like a good idea at the time.
* Removed unused variable ParseMaster::$TRIM.
* To test it, I ran the old and new jquery.js output through Google Closure Compiler. The result was the same, proving that there are no functional differences.
Alexandre Emsenhuber [Fri, 18 Feb 2011 12:25:22 +0000 (12:25 +0000)]
* Use appendQueryValue() instead of appendQuery() so that if e.g. printable=no is already present in the URL, it doesn't become printable=no&printable=yes
* Call getLocalURL() on the local Title object instead of $wgTitle in WebRequest
Alexandre Emsenhuber [Fri, 18 Feb 2011 11:55:11 +0000 (11:55 +0000)]
We have already have a printable flag in the OutputPage object, so use it.
This was causing to have the printable version for every non-empty version of the printable paramter, instead of only for "yes".
Happy-melon [Fri, 18 Feb 2011 11:27:33 +0000 (11:27 +0000)]
(bug 27526) B/C in Special:EmailUser
Raimond Spekking [Fri, 18 Feb 2011 11:20:49 +0000 (11:20 +0000)]
Don't clutter the HTML source with useless class=""
Sam Reed [Fri, 18 Feb 2011 10:34:01 +0000 (10:34 +0000)]
Remove useless elseif compare. If the else if is doing the inverse (!) of the original if, it's redundant
Sam Reed [Fri, 18 Feb 2011 10:32:11 +0000 (10:32 +0000)]
Comment out 2 unused lines in JavaScriptDistiller
Tim Starling [Fri, 18 Feb 2011 07:36:11 +0000 (07:36 +0000)]
* For readability, use /x in regexes. Removed the start and end slashes from the input to ParseMaster::add(), to avoid confusion over the lack of a /x modifier in that input.
* Broke up several regexes and added comments, so that humans might be able to understand them.
* Tested md5(minify(jquery.js)) as before. Checked speed, it's the same.
Tim Starling [Fri, 18 Feb 2011 06:54:46 +0000 (06:54 +0000)]
Made the regexes slightly more readable by undoubling the backslashes where possible. Tested by ensuring that the minifier output is the same before and after, with jquery.js as input.
Tim Starling [Fri, 18 Feb 2011 05:55:09 +0000 (05:55 +0000)]
Add the cache key to the filter output, like what we do with the parser cache, to make it easier to debug filter issues.
Sam Reed [Fri, 18 Feb 2011 01:10:38 +0000 (01:10 +0000)]
Remove unused variables
Sam Reed [Fri, 18 Feb 2011 01:06:04 +0000 (01:06 +0000)]
Remove unreachable line in DifferenceEngine
Documentation for ObjectCache.php
Remove unused variables from CompareParsers and PreprocessDump
Sam Reed [Fri, 18 Feb 2011 01:00:05 +0000 (01:00 +0000)]
Fix wrong static calls
Sam Reed [Fri, 18 Feb 2011 00:57:39 +0000 (00:57 +0000)]
Fixup assignment in conditional
Jeroen De Dauw [Fri, 18 Feb 2011 00:48:56 +0000 (00:48 +0000)]
rem not needed die() and made vars actually private
Sam Reed [Fri, 18 Feb 2011 00:33:45 +0000 (00:33 +0000)]
2 subclasses of ResourceLoaderWikiModule implement a duplicate version of getFlip. Move it up into ResourceLoaderWikiModule
(Almost looks like it could all go into ResourceLoaderModule... But that uses a different version, seemingly, the only one. 3 other subclasses of ResourceLoaderModule implement the same version of getFlip as is moved into a parent class here... Seems daft to have a different version in the base abstract class... Minor oversight?)
Some documentation
Roan Kattouw [Thu, 17 Feb 2011 22:36:11 +0000 (22:36 +0000)]
Fix a bug in string recognition in JSDistiller. This *really* fixes bug 27481
Roan Kattouw [Thu, 17 Feb 2011 22:13:52 +0000 (22:13 +0000)]
Version the minifier cache in ResourceLoader
Roan Kattouw [Thu, 17 Feb 2011 22:07:18 +0000 (22:07 +0000)]
Fix for r82344, which causes JSDistiller to stop minifying comments because it thought they were regexes. Make the regex regex a little bit stricter again, forbidding a regex from starting with * and other invalid things that were disallowed prior to r82344 (but still dropping / ) and forbidding multiline regexes
Raimond Spekking [Thu, 17 Feb 2011 21:07:10 +0000 (21:07 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-17 20:45:00 UTC)
Alexandre Emsenhuber [Thu, 17 Feb 2011 19:26:38 +0000 (19:26 +0000)]
Pass the url to ChangesFeed::getFeedObject() instead of grabbing it from $wgTitle
(no use of that function in extensions)
Roan Kattouw [Thu, 17 Feb 2011 19:19:50 +0000 (19:19 +0000)]
Revert r82340, caused something linke bug 27481 where spaces were being wrongly collapsed. Fixed by changing regex to be more flexible in protecting regexes; nothing wrong with being overinclusive in what we're protecting
Mark A. Hershberger [Thu, 17 Feb 2011 18:41:44 +0000 (18:41 +0000)]
Followup bug #27447 and r82308 and r82328 with patch supplied by
Carsten Nielsen to take care of the warning and supply some
documentation. Also fixed up language in the comments.
Roan Kattouw [Thu, 17 Feb 2011 17:08:06 +0000 (17:08 +0000)]
(bug 27492) Fix regexes for matching JS regexes which could get messed up by the minifier in extreme circumstances
Alexandre Emsenhuber [Thu, 17 Feb 2011 17:06:06 +0000 (17:06 +0000)]
* Don't use assignment in a condition check
* Pass the Title object so that it doesn't rely on $wgTitle
Victor Vasiliev [Thu, 17 Feb 2011 16:29:13 +0000 (16:29 +0000)]
Fix broken Special:Newpages Atom feed.
Raimond Spekking [Thu, 17 Feb 2011 15:39:38 +0000 (15:39 +0000)]
Per r82285: Add new messages for the default user groups. This way they can be found in Special:AllMessages at least.
Messages fot WMF specific user groups can be added to WikimediaMessages.i18n.php when the function is live.
Niklas Laxström [Thu, 17 Feb 2011 10:12:05 +0000 (10:12 +0000)]
Rv part of r82308 that causes warnings
X! [Thu, 17 Feb 2011 00:30:19 +0000 (00:30 +0000)]
Reverting r76017 per discussion on Bugzilla. Lack of community consensus for change, and the whole purpose of the "new messages" box is *NOT* to fit into the skin, so people will see it immediately.
Krinkle [Thu, 17 Feb 2011 00:04:03 +0000 (00:04 +0000)]
more capitalization and less abbrevative ('T', 'err')
Sam Reed [Wed, 16 Feb 2011 23:38:21 +0000 (23:38 +0000)]
* (bug 27479) API error when using both prop=pageprops and prop=info&inprop=displaytitle
Followup r75282
Patch by Brad Jorsch
Krinkle [Wed, 16 Feb 2011 23:27:04 +0000 (23:27 +0000)]
Follow-up r82310. using mw.config instead
Krinkle [Wed, 16 Feb 2011 23:23:04 +0000 (23:23 +0000)]
Adding function to check if the current page is the main space or (optionally) related to the main page (eg. talk page). Compatible with both Vector and Monobook. Both namespace and page title may contain spaces (eg. Wiktionary talk:Main Page)
Mark A. Hershberger [Wed, 16 Feb 2011 23:21:19 +0000 (23:21 +0000)]
followup r82181 and r82215 to fix the FIXME and botched fix for FIXME.
Patch supplied by DieBuche (bug #27338) along with screenshot
demonstrating fix.
Took out fix for bug #27458 (“<gallery> has a white background now”)
since bug it conflicts with a fix for bug #26470.
Mark A. Hershberger [Wed, 16 Feb 2011 23:05:38 +0000 (23:05 +0000)]
(Bug #27447) Added option to toolbar-item to switch off text-selection
Carsten Nielsen explains:
A client of mine was a bit annoyed by the editor:
Every time he inserted - lets say - an image, the default contents of the
image-fields "thumbs|width|caption...." were automatically marked/selected. So
with a tip on the keyboard all "helping" text was gone.
I added an option to the toolbar-items to optional deactivate this behaviour.
Derk-Jan Hartman [Wed, 16 Feb 2011 22:45:30 +0000 (22:45 +0000)]
Add support for namespace prefixed elements in svg. ie. <svg:svg>
Fixes bug 27465
Happy-melon [Wed, 16 Feb 2011 22:29:52 +0000 (22:29 +0000)]
Revert r78585. While I definitely think this is an area where there's scope for improvement in clarity and security, I'm no longer convinced that this is the way to proceed.
Platonides [Wed, 16 Feb 2011 21:30:54 +0000 (21:30 +0000)]
Fix the issue where all links on Special:Contributions where marked as stubs (NS_MAIN pages, for users with a stub threshold) broken since r63584.
resetArticleId() is clearing the right data set by Title::newFromRow() and placing just the id, which in turn avoids to lookup the other items.
This was already done in 1.16 (since r46179, it was useful until r46181) but resetArticleID() did not reset everything (r63584 change) and so
the bug wasn't present there.
Raimond Spekking [Wed, 16 Feb 2011 21:00:04 +0000 (21:00 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-16 20:35:00 UTC)
Bryan Tong Minh [Wed, 16 Feb 2011 20:37:16 +0000 (20:37 +0000)]
jQueryize the toggle upload source type code
Happy-melon [Wed, 16 Feb 2011 19:54:02 +0000 (19:54 +0000)]
Create a user.groups module in ResourceLoader, which bundles a CSS and JS page for each usergroup the user is a member of (MediaWiki:Sysop.js, MediaWiki:Autoconfirmed.css, etc). Groups '*' and 'user' are not included.
Happy-melon [Wed, 16 Feb 2011 19:51:25 +0000 (19:51 +0000)]
revert r82283, loads of unrelated changes
Happy-melon [Wed, 16 Feb 2011 19:49:37 +0000 (19:49 +0000)]
Create a user.groups module in ResourceLoader, which bundles a CSS and JS page for each usergroup the user is a member of (MediaWiki:Sysop.js, MediaWiki:Autoconfirmed.css, etc). Groups '*' and 'user' are not included.
Raimond Spekking [Wed, 16 Feb 2011 19:44:13 +0000 (19:44 +0000)]
Add new message key from r80240 to message file. This way it can be found in Special:AllMessages at least.
Alexandre Emsenhuber [Wed, 16 Feb 2011 18:25:44 +0000 (18:25 +0000)]
Moved Skin::makeGlobalVariablesScript() to OutputPage::getJSVars()
* merged <script> and if ( window.mediaWiki ) block with the one of mediaWiki.loader as stated in the doc
* removed dependency of $wgTitle
* the two only calls to this functions are in SemanticForms, but will not affect current version of MediaWiki:
** specials/SF_UploadWindow.php: this file is only used before 1.16
** specials/SF_UploadWindow2.php: the call is part of the else branch of a "method_exists( $wgOut, 'addModules' )" check, which means it's not called since 1.17
Roan Kattouw [Wed, 16 Feb 2011 17:31:53 +0000 (17:31 +0000)]
Fix fatal in r82258
Roan Kattouw [Wed, 16 Feb 2011 17:06:24 +0000 (17:06 +0000)]
Per Philip Tzou, move wgUserVariant from the set of config variables to the set of pageview-specific variables, because it depends on user settings and such
Philip Tzou [Wed, 16 Feb 2011 16:07:58 +0000 (16:07 +0000)]
revert r77452, r80492 and r82246.
Roan Kattouw [Wed, 16 Feb 2011 14:28:26 +0000 (14:28 +0000)]
Expose $wgExtensionAssetsPath in JS
Philip Tzou [Wed, 16 Feb 2011 14:18:43 +0000 (14:18 +0000)]
Follow r77452, r80492. Avoid to find sub-languages when load css/js messages.
Roan Kattouw [Wed, 16 Feb 2011 11:28:58 +0000 (11:28 +0000)]
(bug 26603) returnto parameter in login link not escaped when viewed on Special:Userlogout
Sam Reed [Wed, 16 Feb 2011 10:28:24 +0000 (10:28 +0000)]
Fix text description of OutputPage::getLanguageLinks(), it doesn't return 'fr' => 'Title', it returns 'fr:Title'
Tim Starling [Wed, 16 Feb 2011 07:24:36 +0000 (07:24 +0000)]
* Fix for r81960: List the local magic word synonyms first, so that they will be returned by $magic->getSynonym( 0 ). Apply array_values() to fix up the keys, potentially corrupted by array_unique().
* In MagicWord::initRegex(), put the longest synonyms first in the alternation. This means that when one synonym is an initial substring of another, the longest one will match in precedence, which is generally in line with user expectations.
Roan Kattouw [Wed, 16 Feb 2011 07:19:33 +0000 (07:19 +0000)]
(bug 27302) Don't append the current timestamp for user/site modules when no user/site JS/CSS is present. Was caused by 1 being rounded down to 0, which is interpreted as 'now' by wfTimestamp(). This revision just drops timestamp rounding because it's not used consistently anyway
Roan Kattouw [Wed, 16 Feb 2011 06:27:22 +0000 (06:27 +0000)]
Followup r82156: skip relative URLs with absolute paths too
Mark A. Hershberger [Wed, 16 Feb 2011 03:38:16 +0000 (03:38 +0000)]
re r82181 remove min-height that doesn't work with IE6
Krinkle [Tue, 15 Feb 2011 23:45:57 +0000 (23:45 +0000)]
Adding italics for .watchlistredir
* Adding comment about Special:PrefixIndex (uses same class as Special:AllPages).
* Follow-up r78964: Adding them for .watchlistredir as well (was forgotten)
Trevor Parscal [Tue, 15 Feb 2011 22:14:03 +0000 (22:14 +0000)]
Grouped diff and history modules together to help reduce cache invalidation. Loaded diff styles statically. This should help with bug #27418, but I suspect there are more cases where we need to do this sort of thing before the bug is truly resolved.
Raimond Spekking [Tue, 15 Feb 2011 21:04:37 +0000 (21:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-15 20:47:00 UTC)
Mark A. Hershberger [Tue, 15 Feb 2011 21:02:12 +0000 (21:02 +0000)]
(bug 27435) Wrap with jquery bit per Roan's suggestion
Mark A. Hershberger [Tue, 15 Feb 2011 20:55:54 +0000 (20:55 +0000)]
trailing whitespace fixup
Mark A. Hershberger [Tue, 15 Feb 2011 19:39:45 +0000 (19:39 +0000)]
* (bug 27338) Gallery in 1.17 breaks for audio/video + ogghandler
Patch by DieBuche, who explains the CSS:
If the image height is lower than the line-height, the margin-top
is applied to the top of the line. a very short image will not
follow for 3-4px laters, thus leading to a bigger distance from
the top than it should be. vertical-align:text-top moves the
picture up, so this problem doesn't happen
I've not tested this, but DieBuche and Derk-Jan Hartman tested and
provided screenshots in the bug.
Trevor Parscal [Tue, 15 Feb 2011 00:49:34 +0000 (00:49 +0000)]
Resolves remaining issues in r82000 with remapping relative CSS URLs that contained queries.
Trevor Parscal [Tue, 15 Feb 2011 00:23:06 +0000 (00:23 +0000)]
Resolves bug #27332 - now using absolute positioning with em measurements to layout search controls. Tested in Internet Explore (6, 7 & 8) as well as a few Gecko and Webkit browsers.
Raimond Spekking [Mon, 14 Feb 2011 21:56:30 +0000 (21:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-14 21:31:00 UTC)
Roan Kattouw [Mon, 14 Feb 2011 19:55:20 +0000 (19:55 +0000)]
(bug 27402) Add support for disabling MWSuggest
Chad Horohoe [Mon, 14 Feb 2011 17:16:39 +0000 (17:16 +0000)]
Allow callback to be set by options array, inspired by bug 27391
Chad Horohoe [Mon, 14 Feb 2011 17:01:42 +0000 (17:01 +0000)]
Add some newlines to generateSitemap output, bug 26134
Sam Reed [Mon, 14 Feb 2011 14:09:25 +0000 (14:09 +0000)]
Explicitally define $domain
Documentation
Raimond Spekking [Mon, 14 Feb 2011 07:43:07 +0000 (07:43 +0000)]
Follow-up r82102 for maintenance file
Brion Vibber [Mon, 14 Feb 2011 03:10:08 +0000 (03:10 +0000)]
* (bug 26298) Throw warning instead of silently saving blank page when php-suhosin removes wpTextbox1 for being 'too long' or some such
To resolve this, edit your php.ini and raise the limits in suhosin.request.max_value_length and suhosin.post.max_value_length settings to more reasonable values.
As a helper for users hit by this, I've made a tweak on trunk in rXXXXX to check for the case of a missing wpTextbox1 field (which I can confirm when installing Suhosin and setting the suhosin.request.max_value_length absurdly low). This extends the previous behavior to check for incomplete form submissions by just checking if the edittime (a late field) is present; and also I added a message to show when it forces those previews.
So now when someone hits this sort of filter, it'll force a preview. Unfortunately that'll show a big empty box, but at least you'll know it's because something went wrong, and it won't save it silently...
Adds UI message 'edit_form_incomplete' with default English value. It's fairly generic as we can't know whether the field was filtered for length, content, or what.
Brion Vibber [Mon, 14 Feb 2011 00:54:40 +0000 (00:54 +0000)]
* (bug 25571) Xml::encodeJsVar now passes floats natively instead of converting to strings
Added unit test cases for int, float, and strings that look like int or float.
Greg Sabino Mullane [Mon, 14 Feb 2011 00:36:36 +0000 (00:36 +0000)]
Not sure I like the DROP stuff here, but let's exclude it from this script.
Brion Vibber [Mon, 14 Feb 2011 00:32:13 +0000 (00:32 +0000)]
* (bug 25675) Fix search suggestions for Special: pages with spaces
Patch by Umherirrender on https://bugzilla.wikimedia.org/show_bug.cgi?id=25675 - normalizes spaces to underscores for our direct alias list comparison.
The current English names mostly use CamelCase, but this is visible with eg German localization, where ExpandTemplates extension has [[Spezial:Vorlagen expandieren]].
Aaron Schulz [Sun, 13 Feb 2011 23:30:26 +0000 (23:30 +0000)]
Follow-up r82093: fixed comment :)
Aaron Schulz [Sun, 13 Feb 2011 23:24:48 +0000 (23:24 +0000)]
* (bug 27353) IPv6 address ending in "::WORD" was not recognized
* Moved down 'contains no "::"' alternative for clarity (and possibly use frequency too)
* Added more IPv6 tests
Aaron Schulz [Sun, 13 Feb 2011 23:20:53 +0000 (23:20 +0000)]
Broke long line
Brion Vibber [Sun, 13 Feb 2011 23:08:28 +0000 (23:08 +0000)]
* (bug 23817, bug 26250) User Service_JSON's native associative array mode in FormatJson::decode(), bypassing wfObjectToArray (which is also fixed)
Patches from Tim Yates on https://bugzilla.wikimedia.org/show_bug.cgi?id=23817
Brion Vibber [Sun, 13 Feb 2011 23:04:34 +0000 (23:04 +0000)]
* (bug 26250, bug 23817) Fix wfObjectToArray() to descend into arrays; fixes processing of JSON return values for ForeignAPIRepo when native json module not present
Raimond Spekking [Sun, 13 Feb 2011 21:35:25 +0000 (21:35 +0000)]
Bug 27385 - Set Polish $namespaceGenderAliases (r82029)
Raimond Spekking [Sun, 13 Feb 2011 21:28:13 +0000 (21:28 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-13 21:00:00 UTC)
Brion Vibber [Sun, 13 Feb 2011 21:20:02 +0000 (21:20 +0000)]
* (bug 27377) Fix Special:Listfile user selector when initial form parameters already set
Follow-up to r68096: fix field name when blacklisting for hidden fields.
The user field ended up getting copied into the hidden fields due to wrong name in the getHiddenFields() call.